kevinrr888 commented on code in PR #5479:
URL: https://github.com/apache/accumulo/pull/5479#discussion_r2049551277


##########
server/base/src/test/java/org/apache/accumulo/server/util/TableDiskUsageTest.java:
##########
@@ -75,17 +72,20 @@ public static void beforeClass() {
 
   @Test
   public void testSingleTableMultipleTablets() throws Exception {
-    final ServerContext client = EasyMock.createMock(ServerContext.class);
-    final Scanner scanner = EasyMock.createMock(Scanner.class);
-    mockScan(client, scanner, 1);
+    final ClientContext client = EasyMock.createMock(ClientContext.class);

Review Comment:
   Yeah I agree the mocking that's done for this test now is definitely not 
ideal. I did not consider doing something like that, but you're right it would 
have made things a lot simpler for the test here. I'll be keeping this in mind 
for future changes, thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to