dlmarion commented on code in PR #5490:
URL: https://github.com/apache/accumulo/pull/5490#discussion_r2052895109
##########
core/src/main/java/org/apache/accumulo/core/clientImpl/OfflineIterator.java:
##########
@@ -345,9 +245,13 @@ private SortedKeyValueIterator<Key,Value>
createIterator(KeyExtent extent,
MultiIterator multiIter = new MultiIterator(readers, extent);
- OfflineIteratorEnvironment iterEnv =
- new OfflineIteratorEnvironment(context, tableId, authorizations,
tableCC, false,
- samplerConfImpl == null ? null :
samplerConfImpl.toSamplerConfiguration());
+ ClientIteratorEnvironment.Builder iterEnvBuilder =
+ new
ClientIteratorEnvironment.Builder().withAuthorizations(authorizations)
+
.withScope(IteratorScope.scan).withTableId(tableId).withClient(context);
+ if (scannerSamplerConfig != null) {
+ iterEnvBuilder.withSamplerConfiguration(scannerSamplerConfig);
+ }
+ IteratorEnvironment iterEnv = iterEnvBuilder.build();
Review Comment:
The old code set useSampling to `false`, but went to the trouble of creating
the `sampleConfiguration`. I'm wondering if setting `useSampling` to `false`
was a bug in the old version.
https://github.com/apache/accumulo/blob/3912b36d0b0ca103b7068d7c7575c99d32a11a97/core/src/main/java/org/apache/accumulo/core/clientImpl/OfflineIterator.java#L324-L331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
