ctubbsii commented on code in PR #5487:
URL: https://github.com/apache/accumulo/pull/5487#discussion_r2054966995
##########
core/src/main/java/org/apache/accumulo/core/clientImpl/ClientTabletCacheImpl.java:
##########
@@ -632,7 +632,7 @@ private void requestTabletHosting(ClientContext context,
}
// System tables should always be hosted
- if (AccumuloTable.ROOT.tableId() == tableId ||
AccumuloTable.METADATA.tableId() == tableId) {
+ if (AccumuloTable.allTableIds().contains(tableId)) {
Review Comment:
I think the class `AccumuloTable` is really a misnomer. It's really
`TablesInTheAccumuloNamespace`, and would probably be more intuitive if named
`AccumuloNamespace`, with methods like `.containsTable(tableId)`, or
`.tables().contains(TableId)`. There are several places in the code that have
this pattern of checking that a tableId is contained in this set that would
benefit from such a change. A similar comment was made on #5451
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
