keith-turner commented on PR #5490: URL: https://github.com/apache/accumulo/pull/5490#issuecomment-2825447104
> I'm not sure about the change I made in https://github.com/apache/accumulo/commit/1c75b6c646bbd4bf5d7cdfff7d387445ff636445. With the builder pattern should we allow the user to call whatever methods they want in which-ever order they want? That change is nice for runtime validation. Could add more runtime checks making sure things are empty when set in the builder w/ the assumption that if the same builder method is called twice it probably is not what was intended. I like the way it currently is, the optionals provide a lot of runtime validation (like for the case attempting to use something not set in the builder). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
