ctubbsii commented on code in PR #5498: URL: https://github.com/apache/accumulo/pull/5498#discussion_r2056846087
########## core/src/main/java/org/apache/accumulo/core/metadata/AccumuloNamespace.java: ########## @@ -28,7 +28,7 @@ /** * Defines the name and id of all tables in the accumulo table namespace. */ -public enum AccumuloTable { +public enum AccumuloNamespace { Review Comment: System is a well-known class name in Java, and I think that something like that may be too generically named. SystemSchema might work, but I'm having trouble thinking of this as a "schema" in any sense of that word I'm familiar with. "SystemTables" seemed to satisfy what you were thinking to me. At its most terse, maybe: ```java Namespace namespace(); Map<TableId,String> mapping(); ``` In use: ```java boolean isSystemNamespace = SystemTables.namespace().id().equals(namespaceId); boolean isSystemTable = SystemTables.mapping().keySet().contains(tableId); ``` But that's a lot of boilerplate, so having extra methods might help: ```java String namespaceName(); NamespaceId namespaceId(); Set<TableId> tableIds(); boolean containsTableId(TableId tableId); boolean containsTableName(String tableName); Map<String,String> tableIdToNameMap(); ``` Either way, terse or verbose, I think the name "SystemTables" works. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org