kevinrr888 commented on code in PR #5490: URL: https://github.com/apache/accumulo/pull/5490#discussion_r2058713933
########## core/src/test/java/org/apache/accumulo/core/iterators/DefaultIteratorEnvironment.java: ########## @@ -1,56 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at - * - * https://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, - * software distributed under the License is distributed on an - * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY - * KIND, either express or implied. See the License for the - * specific language governing permissions and limitations - * under the License. - */ -package org.apache.accumulo.core.iterators; - -import java.io.IOException; - -import org.apache.accumulo.core.conf.AccumuloConfiguration; -import org.apache.accumulo.core.conf.DefaultConfiguration; -import org.apache.accumulo.core.data.Key; -import org.apache.accumulo.core.data.Value; -import org.apache.accumulo.core.iteratorsImpl.system.MapFileIterator; -import org.apache.hadoop.conf.Configuration; -import org.apache.hadoop.fs.FileSystem; - -public class DefaultIteratorEnvironment implements IteratorEnvironment { - - AccumuloConfiguration conf; - Configuration hadoopConf = new Configuration(); - - public DefaultIteratorEnvironment(AccumuloConfiguration conf) { - this.conf = conf; - } - - public DefaultIteratorEnvironment() { - this.conf = DefaultConfiguration.getInstance(); - } - - @Deprecated(since = "2.0.0") - @Override - public SortedKeyValueIterator<Key,Value> reserveMapFileReader(String mapFileName) - throws IOException { - FileSystem fs = FileSystem.get(hadoopConf); - return new MapFileIterator(fs, mapFileName, hadoopConf); - } Review Comment: I may be missing something, but seems like the replacement `public static final IteratorEnvironment DEFAULT = new Builder().build();` for this class will `throw new UnsupportedOperationException("Feature not supported");` for this method. If DEFAULT is only used in testing this probably doesn't matter so long as everything still passes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
