kevinrr888 commented on code in PR #5512:
URL: https://github.com/apache/accumulo/pull/5512#discussion_r2063940349
##########
core/src/main/java/org/apache/accumulo/core/client/rfile/RFileScanner.java:
##########
@@ -107,17 +105,13 @@ public Configuration getConfiguration() {
@Override
public Configuration getConfiguration(TableId tableId) {
- Preconditions.checkArgument(tableId == TABLE_ID, "Expected " + TABLE_ID
+ " obtained"
- + " from IteratorEnvironment.getTableId(), but got: " + tableId);
return tableConf;
}
}
private static final byte[] EMPTY_BYTES = new byte[0];
private static final Range EMPTY_RANGE = new Range();
- private static final String TABLE_NAME = "rfileScanner";
- private static final TableId TABLE_ID = TableId.of(TABLE_NAME);
Review Comment:
Yeah, this is a weird case where we need to pretend there is a table id when
there isn't. I'm fine also not validating it, my idea was just that we should
expect `env.getTableId()` as the way of getting the table id when it is needed
instead of accepting any table id
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
