DomGarguilo commented on code in PR #5511:
URL: https://github.com/apache/accumulo/pull/5511#discussion_r2069242475


##########
server/monitor/src/main/java/org/apache/accumulo/monitor/next/Endpoints.java:
##########
@@ -57,6 +57,15 @@
 
 @Path("/")
 public class Endpoints {
+  /**
+   * A {@code String} constant representing supplied resource group
+   */
+  private static final String GROUP = "group";
+
+  /**
+   * A {@code String} constant representing supplied tableId.
+   */
+  private static final String TABLEID = "tableId";

Review Comment:
   ```suggestion
     /**
      * A {@code String} constant representing supplied resource group
      */
     private static final String GROUP = "group";
   
     /**
      * A {@code String} constant representing supplied tableId.
      */
     private static final String TABLEID = "tableId";
   ```
   I think it might be better to update these to make it more evident that 
these are the parameter keys. Maybe something like `GROUP_PARAM_KEY` AND 
`TABLEID_PARAM_KEY`. The javadoc should be updated to reflect this if the 
change is made.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to