ctubbsii commented on code in PR #460: URL: https://github.com/apache/accumulo-website/pull/460#discussion_r2069544462
########## Dockerfile: ########## @@ -17,16 +17,17 @@ WORKDIR /mnt/workdir # from the mounted directory. But that's not available during the # docker build, so we need to copy them in to pre-install the Gems -COPY Gemfile ./Gemfile -COPY Gemfile.lock ./Gemfile.lock +COPY Gemfile Gemfile.lock ./ # Gems will be installed under GEM_HOME which is set by the ruby image. # See https://hub.docker.com/_/ruby for details. -RUN gem update --system && bundle install && gem cleanup +RUN gem update --system \ + && bundle install \ + && gem cleanup Review Comment: I don't know how Dockerfiles are parsed, but in bash, the backslash is redundant if the line ends with `&&`, as in: ``` RUN gem update --system && bundle install && gem cleanup ``` This is even easier to read, but I don't know if it works the same in Dockerfiles. ########## Dockerfile: ########## @@ -17,16 +17,17 @@ WORKDIR /mnt/workdir # from the mounted directory. But that's not available during the # docker build, so we need to copy them in to pre-install the Gems -COPY Gemfile ./Gemfile -COPY Gemfile.lock ./Gemfile.lock +COPY Gemfile Gemfile.lock ./ # Gems will be installed under GEM_HOME which is set by the ruby image. # See https://hub.docker.com/_/ruby for details. -RUN gem update --system && bundle install && gem cleanup +RUN gem update --system \ + && bundle install \ + && gem cleanup -ENV HOST=0.0.0.0 -ENV PORT=4000 +ENV HOST=0.0.0.0 \ + PORT=4000 Review Comment: I think it's better as two separate `ENV` lines. They are two independent environment declarations. This new syntax makes it seem like the two are related in some way, and might be confused with something like `ENV PROPWITHEMBEDDEDSPACE=0.0.0.0\ 4000` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
