dlmarion commented on PR #5516: URL: https://github.com/apache/accumulo/pull/5516#issuecomment-2844702439
> Overall, these changes look okay. However, I would prefer to fix the tests as well. The code quality checks done by these QA plugins are just as valid on test code as they are on non-test code. The test code should not be excluded. If it's broken up into two commits, that's fine, but I don't think we should be adding rules to exclude them in the pom.xml My intention was to create follow-on issues for the main branch to remove the exclusions from the pom possibly allowing the work to be distributed across more people. > Also, when I update build plugins, I generally try to update build plugins for the earlier branches that we are still supporting as well, since it affects build stability and code quality checks that can catch problems. This targets the main branch. I'd be interested in considering backporting the plugin updates to the 2.1 branch, so that its next release also benefits from any bugfixes or quality improvements in the build for its next release. I don't know that any of these changes fix any bugs, I think they are just performance improvements File I/O that stem from [this](https://github.com/gaul/modernizer-maven-plugin/pull/301). There is a follow-on issue [here](https://github.com/gaul/modernizer-maven-plugin/issues/303) which I ran into and had to remember to use `Paths.of` when the modernizer plugin was suggesting `Paths.get`. Since the majority of our File I/O is performed by Hadoop, these changes will only help utility code and the currently un-fixed tests. I don't think we will see any real performance gain from these changes on a deployed system. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
