DomGarguilo commented on code in PR #5540:
URL: https://github.com/apache/accumulo/pull/5540#discussion_r2082070019
##########
core/src/main/java/org/apache/accumulo/core/clientImpl/TableOperationsImpl.java:
##########
@@ -1220,42 +1220,33 @@ public Map<String,String> getTableProperties(final
String tableName)
}
@Override
- public void setLocalityGroups(String tableName, Map<String,Set<Text>> groups)
+ public void setLocalityGroups(String tableName, Map<String,Set<Text>>
groupsToSet)
throws AccumuloException, AccumuloSecurityException,
TableNotFoundException {
// ensure locality groups do not overlap
- LocalityGroupUtil.ensureNonOverlappingGroups(groups);
+ LocalityGroupUtil.ensureNonOverlappingGroups(groupsToSet);
- for (Entry<String,Set<Text>> entry : groups.entrySet()) {
- Set<Text> colFams = entry.getValue();
- String value = LocalityGroupUtil.encodeColumnFamilies(colFams);
- setPropertyNoChecks(tableName, Property.TABLE_LOCALITY_GROUP_PREFIX +
entry.getKey(), value);
Review Comment:
Looks like its not a bug. `Property.toString()` is as follows:
```java
@Override
public String toString() {
return this.key;
}
```
Confirmed in an `uno jshell` shell too:
```
jshell> import org.apache.accumulo.core.conf.Property
jshell> String test = Property.TABLE_LOCALITY_GROUP_PREFIX + "";
test ==> "table.group."
jshell> String test2 = Property.TABLE_LOCALITY_GROUP_PREFIX.getKey() + "";
test2 ==> "table.group."
```
Definitely seems better to explicitly use `getKey()` but functionally the
same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
