keith-turner commented on code in PR #5543:
URL: https://github.com/apache/accumulo/pull/5543#discussion_r2084823060
##########
core/src/main/java/org/apache/accumulo/core/util/threads/Threads.java:
##########
@@ -66,4 +71,17 @@ public static Thread createThread(String name, OptionalInt
priority, Runnable r,
return thread;
}
+ public static Thread createCriticalThread(String name, Runnable r) {
+ Runnable wrapped = () -> {
+ try {
+ r.run();
+ } catch (RuntimeException e) {
+ String msg = "Critical thread " + name + " died";
+ log.error(msg, e);
+ Halt.halt(msg);
Review Comment:
Updated in 22e5eec.
> I think you should just call Runtime.getRuntime().halt(int); here.
Halt.halt(String) creates a Thread to log the msg, then calls
Runtime.halt(int). For the same reason as above, the log msg may never make it
to the log.
Should we open an issue to fix this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
