meatballspaghetti opened a new pull request, #5549: URL: https://github.com/apache/accumulo/pull/5549
This PR is to better organize and reduce zookeeper lookups by moving ZooKeeper Tables to under the `/namespaces` Node under their respective namespaces. Detailed explanation in #5414 , which is the issue that this PR resolves. In this change, although we are moving tables from under` /accumulo/<iid>/tables`, we will maintain this node to hold the counter for generating table IDs. With this in mind, the Constant for this node has been renamed from` ZTABLES` to `ZTABLE_ID_COUNTER`. Core Files changed for implementation: - `Constants`: Rename ` ZTABLES` to `ZTABLE_ID_COUNTER` and delete `ZTABLE_NAMESPACE` - `TablePropKey` and other paths to ZK Tables: Modified to include the Namespace ID for the path to a given table, which is typically retrieved through `ClientContext.getNamespaceId(TableId)` (unless the given code already has a namespace ID). Any code that uses this now includes a try-catch block to handle` TableNotFoundException`. - `PropStoreKey`: Simplify path matching to determine if given path is for System-, Namespace-, or TablePropKey. - `TableManager`: Modify path for zookeeper table creation and no longer create table namespace node. - ` Upgrader10to11` + Test: `Upgrader10to11` takes place before the ZK table moving occurs in `Upgrader12to13`, and it uses `TablePropKey` which now assumes the new path to the ZK tables. Therefore, created inner class to allow use of a PropKey with old path. - ` Upgrader12to13` + Test: Create upgrade code that will copy tables and their child nodes in zookeeper from under `/tables` node to their respective namespaces under `/namespaces` node; delete the tables and their child nodes from old location; delete the `/tables/<tableid>/namespace` nodes. Resolves #5414 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
