dlmarion commented on code in PR #5573:
URL: https://github.com/apache/accumulo/pull/5573#discussion_r2102382124
##########
server/compactor/src/main/java/org/apache/accumulo/compactor/Compactor.java:
##########
@@ -386,6 +386,8 @@ protected void updateCompactionState(TExternalCompactionJob
job, TCompactionStat
ThriftUtil.returnClient(coordinatorClient, getContext());
}
});
+ LOG.trace("Attempting to update compaction state in coordinator ECID:{}",
Review Comment:
If you move this up into the function (line 382), then it will get logged on
every retry. Putting it here, it will only be logged once.
##########
server/compactor/src/main/java/org/apache/accumulo/compactor/Compactor.java:
##########
@@ -386,6 +386,8 @@ protected void updateCompactionState(TExternalCompactionJob
job, TCompactionStat
ThriftUtil.returnClient(coordinatorClient, getContext());
}
});
+ LOG.trace("Attempting to update compaction state in coordinator ECID:{}",
Review Comment:
ExternalCompactionId has a prefix of `ECID:` already. I think that gets
returned in the String from the `toString` method. If so, then this would end
up with two `ECID` in the log statement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
