kevinrr888 opened a new pull request, #5576: URL: https://github.com/apache/accumulo/pull/5576
- Identified and updated which threads should or shouldn't be critical to the process they are running in (previously, all threads created were non-critical). "Critical" meaning if an (unhandled) `RuntimeException` occurs in the thread, the process should be halted. All threads (i.e., those created through both `createNonCriticalThread` or `createCriticalThread`) already halt the process if an `Error` occurs via the `AccumuloUncaughtExceptionHandler`. So, now we handle all cases of unchecked exceptions (`Error` and `RuntimeException`): all `Error`s will result in `halt()` and we choose whether or not a `RuntimeException` will result in `halt()`. - Renamed `Threads.createThread()` to `Threads.createNonCriticalThread()` to ensure callers consider which method to use. I have provided my reasoning for each of the decisions for critical vs non critical, in case they are helpful in review. Something still left todo for this is to review the threads in 4.0 and determine if there are any new threads there that need to be considered. Will look into this now. closes #5546 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
