dlmarion commented on code in PR #5575:
URL: https://github.com/apache/accumulo/pull/5575#discussion_r2109767959


##########
server/manager/src/main/java/org/apache/accumulo/manager/Manager.java:
##########
@@ -1917,19 +1920,22 @@ public boolean isUpgrading() {
     return upgradeCoordinator.getStatus() != 
UpgradeCoordinator.UpgradeStatus.COMPLETE;
   }
 
-  void initializeBalancer() {
+  private void initializeBalancer() {
+    String configuredBalancerClass = 
getConfiguration().get(Property.MANAGER_TABLET_BALANCER);
     try {
-      getContext().getPropStore().getCache().removeAll();
-      getConfiguration().invalidateCache();
-      log.debug("Attempting to reinitialize balancer using class {}",
-          getConfiguration().get(Property.MANAGER_TABLET_BALANCER));
-      var localTabletBalancer = 
Property.createInstanceFromPropertyName(getConfiguration(),
-          Property.MANAGER_TABLET_BALANCER, TabletBalancer.class, new 
DoNothingBalancer());
-      localTabletBalancer.init(balancerEnvironment);
-      tabletBalancer = localTabletBalancer;
+      if (tabletBalancer == null
+          || 
!tabletBalancer.getClass().getName().equals(configuredBalancerClass)) {
+        log.debug("Attempting to initialize balancer using class {}, was {}",
+            configuredBalancerClass,
+            tabletBalancer == null ? "null" : 
tabletBalancer.getClass().getName());
+        var localTabletBalancer = 
Property.createInstanceFromPropertyName(getConfiguration(),
+            Property.MANAGER_TABLET_BALANCER, TabletBalancer.class, new 
DoNothingBalancer());
+        localTabletBalancer.init(balancerEnvironment);
+        tabletBalancer = localTabletBalancer;

Review Comment:
   Added log stmt in fcd25da



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to