ctubbsii commented on code in PR #5581: URL: https://github.com/apache/accumulo/pull/5581#discussion_r2110570716
########## test/src/main/java/org/apache/accumulo/test/fate/FateExecutionOrderIT.java: ########## @@ -55,19 +55,16 @@ import org.apache.accumulo.core.fate.FateId; import org.apache.accumulo.core.fate.FateStore; import org.apache.accumulo.core.fate.Repo; -import org.apache.accumulo.harness.AccumuloITBase; import org.apache.accumulo.harness.SharedMiniClusterBase; import org.apache.accumulo.server.ServerContext; import org.apache.hadoop.io.Text; import org.junit.jupiter.api.AfterAll; import org.junit.jupiter.api.BeforeAll; import org.junit.jupiter.api.BeforeEach; -import org.junit.jupiter.api.Tag; import org.junit.jupiter.api.Test; import com.google.common.collect.Iterators; -@Tag(AccumuloITBase.SIMPLE_MINI_CLUSTER_SUITE) public abstract class FateExecutionOrderIT extends SharedMiniClusterBase Review Comment: The abstract classes shouldn't really end in "IT", because they aren't ITs. It looks like this is a pre-existing issue, and the same issue I already mentioned with ComprehensiveBaseIT. It's not particularly important... it's just a little confusing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
