dlmarion commented on code in PR #5574:
URL: https://github.com/apache/accumulo/pull/5574#discussion_r2112007754


##########
core/src/main/java/org/apache/accumulo/core/util/Halt.java:
##########
@@ -29,27 +31,43 @@ public class Halt {
   private static final Logger log = LoggerFactory.getLogger(Halt.class);
 
   public static void halt(final String msg) {
-    // ACCUMULO-3651 Changed level to error and added FATAL to message for 
slf4j compatibility
-    halt(0, new Runnable() {
-      @Override
-      public void run() {
-        log.error("FATAL {}", msg);
-      }
-    });
+    halt(0, msg, Optional.empty(), null);
   }
 
-  public static void halt(final String msg, int status) {
-    halt(status, new Runnable() {
-      @Override
-      public void run() {
-        log.error("FATAL {}", msg);
-      }
-    });
+  public static void halt(final String msg, final int status) {
+    halt(status, msg, Optional.empty(), null);
   }
 
-  public static void halt(final int status, Runnable runnable) {
+  public static void halt(final int status, final String msg, final 
Optional<Throwable> exception) {
+    halt(status, msg, exception, null);
+  }
+
+  public static void halt(final int status, final String msg, final Runnable 
runnable) {
+    halt(status, msg, Optional.empty(), runnable);
+  }
 
+  public static void halt(final int status, final String msg, final 
Optional<Throwable> exception,
+      final Runnable runnable) {

Review Comment:
   I removed the Optional in e0910de.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to