Re: [PR] avoid abstract classes ending in 'IT' [accumulo]

[via GitHub]

ctubbsii commented on code in PR #5585:
URL: https://github.com/apache/accumulo/pull/5585#discussion_r2112578338


##########
test/src/main/java/org/apache/accumulo/test/fate/user/FateMutatorImplIT_SimpleSuite.java:
##########
@@ -79,21 +79,26 @@ public void putRepo() throws Exception {
           FateId.from(FateInstanceType.fromNamespaceOrTableName(table), 
UUID.randomUUID());
 
       // add some repos in order
-      FateMutatorImpl<FateIT.TestEnv> fateMutator = new 
FateMutatorImpl<>(context, table, fateId);
-      fateMutator.putRepo(100, new FateIT.TestRepo("test")).mutate();
-      FateMutatorImpl<FateIT.TestEnv> fateMutator1 = new 
FateMutatorImpl<>(context, table, fateId);
-      fateMutator1.putRepo(99, new FateIT.TestRepo("test")).mutate();
-      FateMutatorImpl<FateIT.TestEnv> fateMutator2 = new 
FateMutatorImpl<>(context, table, fateId);
-      fateMutator2.putRepo(98, new FateIT.TestRepo("test")).mutate();
+      FateMutatorImpl<FateITBase.TestEnv> fateMutator =
+          new FateMutatorImpl<>(context, table, fateId);
+      fateMutator.putRepo(100, new FateITBase.TestRepo("test")).mutate();
+      FateMutatorImpl<FateITBase.TestEnv> fateMutator1 =
+          new FateMutatorImpl<>(context, table, fateId);

Review Comment:
   A lot of these could be made more succinct with var:
   
   ```suggestion
         var fateMutator1 = new FateMutatorImpl<FateITBase.TestEnv>(context, 
table, fateId);
   ```
   
   And even shorter if the import was for `FateITBase.TestEnv`:
   
   ```suggestion
         var fateMutator1 = new FateMutatorImpl<TestEnv>(context, table, 
fateId);
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org