keith-turner commented on code in PR #5605:
URL: https://github.com/apache/accumulo/pull/5605#discussion_r2121542344
##########
core/src/main/java/org/apache/accumulo/core/classloader/DefaultContextClassLoaderFactory.java:
##########
@@ -74,7 +74,7 @@ private static void
setContextConfig(Supplier<Map<String,String>> contextConfigS
private static void startCleanupThread(final AccumuloConfiguration conf,
final Supplier<Map<String,String>> contextConfigSupplier) {
ScheduledFuture<?> future =
- ((ScheduledThreadPoolExecutor) ThreadPools.getClientThreadPools((t, e)
-> {
+ ((ScheduledThreadPoolExecutor) ThreadPools.getClientThreadPools(conf,
(t, e) -> {
Review Comment:
Its probably okay in this case because the DefaultContextClassLoaderFactory
class is not in an SPI or API package. Its constructor already takes a non
public AccumuloConfiguration type. As long the change do not require a change
to the interface it implements it seems ok.
##########
core/src/main/java/org/apache/accumulo/core/classloader/DefaultContextClassLoaderFactory.java:
##########
@@ -74,7 +74,7 @@ private static void
setContextConfig(Supplier<Map<String,String>> contextConfigS
private static void startCleanupThread(final AccumuloConfiguration conf,
final Supplier<Map<String,String>> contextConfigSupplier) {
ScheduledFuture<?> future =
- ((ScheduledThreadPoolExecutor) ThreadPools.getClientThreadPools((t, e)
-> {
+ ((ScheduledThreadPoolExecutor) ThreadPools.getClientThreadPools(conf,
(t, e) -> {
Review Comment:
Its probably okay in this case because the DefaultContextClassLoaderFactory
class is not in an SPI or API package. Its constructor already takes a non
public AccumuloConfiguration type. As long the change does not require a
change to the interface it implements it seems ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
