dlmarion commented on code in PR #5599:
URL: https://github.com/apache/accumulo/pull/5599#discussion_r2124790577
##########
server/base/src/main/java/org/apache/accumulo/server/AbstractServer.java:
##########
@@ -65,8 +64,18 @@ protected AbstractServer(String appName, ServerOpts opts,
String[] args) {
this.log = LoggerFactory.getLogger(getClass().getName());
this.applicationName = appName;
opts.parseArgs(appName, args);
- this.hostname = Objects.requireNonNull(opts.getAddress());
var siteConfig = opts.getSiteConfiguration();
+ String oldBindParameter = opts.getAddress();
+ String newBindParameter =
siteConfig.get(Property.RPC_PROCESS_BIND_ADDRESS);
+ if (!oldBindParameter.equals(ServerOpts.BIND_ALL_ADDRESSES) &&
!newBindParameter.equals("")) {
+ throw new IllegalStateException(
+ "Bind address specified via '-a' and '-o rpc.bind.addr=<address>'");
+ }
+ if (oldBindParameter.equals(ServerOpts.BIND_ALL_ADDRESSES) &&
!newBindParameter.equals("")) {
Review Comment:
This code would not break if someone changes the default value I guess is my
point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
