dlmarion commented on code in PR #5599:
URL: https://github.com/apache/accumulo/pull/5599#discussion_r2132631365
##########
server/base/src/main/java/org/apache/accumulo/server/AbstractServer.java:
##########
@@ -65,8 +64,20 @@ protected AbstractServer(String appName, ServerOpts opts,
String[] args) {
this.log = LoggerFactory.getLogger(getClass().getName());
this.applicationName = appName;
opts.parseArgs(appName, args);
- this.hostname = Objects.requireNonNull(opts.getAddress());
var siteConfig = opts.getSiteConfiguration();
+ final String oldBindParameter = opts.getAddress();
+ if (!oldBindParameter.equals(ServerOpts.BIND_ALL_ADDRESSES)
+ && siteConfig.isPropertySet(Property.RPC_PROCESS_BIND_ADDRESS)) {
+ throw new IllegalStateException(
+ "Bind address specified via '-a' and '-o rpc.bind.addr=<address>'");
+ }
+ final String newBindParameter =
siteConfig.get(Property.RPC_PROCESS_BIND_ADDRESS);
+ if (oldBindParameter.equals(ServerOpts.BIND_ALL_ADDRESSES)
+ &&
!newBindParameter.equals(Property.RPC_PROCESS_BIND_ADDRESS.getDefaultValue())) {
+ this.hostname = newBindParameter;
+ } else {
+ this.hostname = oldBindParameter;
+ }
Review Comment:
Added something in 96c972a to try and implement this. Let me know what you
think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
