DomGarguilo commented on PR #5398: URL: https://github.com/apache/accumulo/pull/5398#issuecomment-2971147975
> I am actually not sure that traces are being propagated correctly. I'm looking into things but I don't think this should be merged yet. After debugging. The issue is not fixed via a683811 and I can see spans from client -> server in Jaeger. The issue was that we were not closing the scope or span on `AccumuloProtocol.readMessageEnd()` so the traces were never closed on the server side, and thus those server spans never finished (and couldn’t be linked back to the client spans in Jaeger). In the screenshot below, in a shell I ran `trace on` then `scan` (on an existing table with an entry) then `trace off`.  This demonstrates that cross-component tracing is working. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
