keith-turner commented on code in PR #5664:
URL: https://github.com/apache/accumulo/pull/5664#discussion_r2159504368
##########
server/manager/src/main/java/org/apache/accumulo/manager/TabletGroupWatcher.java:
##########
@@ -429,6 +429,19 @@ private TableMgmtStats
manageTablets(Iterator<TabletManagement> iter,
SortedMap<TServerInstance,TabletServerStatus> currentTServers, boolean
isFullScan)
throws TException, DistributedStoreException, WalMarkerException,
IOException {
+ // When upgrading the Manager needs the TabletGroupWatcher
+ // to assign and balance the root and metadata tables, but
+ // the Manager does not fully start up until the upgrade
+ // is complete. This means that objects like the Splitter
+ // are not going to be initialized and the Coordinator
+ // is not going to be started.
+ final boolean currentlyUpgrading = manager.isUpgrading();
+ if (currentlyUpgrading) {
+ LOG.debug(
+ "Currently upgrading, splits and compactions for tables in level {}
will occur once upgrade is completed.",
+ store.getLevel());
Review Comment:
> If we move that check down into the code where the actions are received
from the TabletManagmentIterator, then the logging will happen once per tablet,
instead of once per cycle.
Yeah do not want to do that. I was only looking at the diff and making a
wrong assumption about where this code was. If it is only logging per TGW
cycle then that is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
