keith-turner commented on code in PR #5537:
URL: https://github.com/apache/accumulo/pull/5537#discussion_r2162094770
##########
server/manager/src/main/java/org/apache/accumulo/manager/Manager.java:
##########
@@ -452,15 +436,14 @@ protected Manager(ConfigOpts opts,
Function<SiteConfiguration,ServerContext> ser
super(ServerId.Type.MANAGER, opts, serverContextFactory, args);
ServerContext context = super.getContext();
upgradeCoordinator = new UpgradeCoordinator(context);
- balancerEnvironment = new BalancerEnvironmentImpl(context);
+ balanceManager = new BalanceManager(this);
AccumuloConfiguration aconf = context.getConfiguration();
log.info("Version {}", Constants.VERSION);
log.info("Instance {}", context.getInstanceID());
timeKeeper = new ManagerTime(this, aconf);
tserverSet = new LiveTServerSet(context, this);
Review Comment:
`this` escaping in the constructor is dicey and we should try to avoid it.
If can not improve in this PR, will open a follow on issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
