ddanielr commented on code in PR #5689:
URL: https://github.com/apache/accumulo/pull/5689#discussion_r2176266654
##########
shell/src/main/java/org/apache/accumulo/shell/commands/QuotedStringTokenizer.java:
##########
@@ -109,7 +110,18 @@ private void createTokens() throws BadArgumentException,
UnsupportedEncodingExce
} else {
token[tokenLength++] = inputBytes[i];
}
+ } else if (inValue) {
+ if (ch != ' ') {
+ token[tokenLength++] = inputBytes[i];
+ } else {
+ inValue = false;
+ tokens.add(new String(token, 0, tokenLength, Shell.CHARSET));
+ tokenLength = 0;
+ }
} else {
+ if (ch == '=') {
+ inValue = true;
+ }
Review Comment:
Confirmed that the check chaining worked and then refactored to use switch
statements when doing constant comparisons. This change made the parsing logic
easier to follow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
