keith-turner commented on code in PR #5692:
URL: https://github.com/apache/accumulo/pull/5692#discussion_r2178395473
##########
minicluster/src/main/java/org/apache/accumulo/miniclusterImpl/MiniAccumuloClusterControl.java:
##########
@@ -213,16 +215,20 @@ public synchronized void start(ServerType server,
Map<String,String> configOverr
Map<String,Integer> compactorGroups =
cluster.getConfig().getClusterServerConfiguration().getCompactorConfiguration();
for (Entry<String,Integer> e : compactorGroups.entrySet()) {
+ final String rg = e.getKey();
Review Comment:
Could do something like the following in MiniAccumuloConfigImpl to support
setting per RG.
```java
private final EnumMap<ServerType,Function<String, Class<?>>>
serverTypeClasses;
// this function allows most existing code to stay the same.
public MiniAccumuloConfigImpl setServerClass(ServerType type, Class<?>
serverClass) {
return setServerClass(type, resourceGroup -> serverClass);
}
public MiniAccumuloConfigImpl setServerClass(ServerType type,
Function<String, Class<?>> serverClassfunction) {
serverTypeClasses.put(type, Objects.requireNonNull(serverClassfunction));
return this;
}
```
Then in a test class could do the followin. Then its no longer hidden,
someone looking at the test code can see what is happening.
```
cfg.setServerClass(ServerType.COMPACTOR, rg->rg.equals("default") ?
Compactor.class : ExternalDoNothingCompactor.class);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
