kevinrr888 commented on code in PR #5715:
URL: https://github.com/apache/accumulo/pull/5715#discussion_r2190912094
##########
core/src/main/java/org/apache/accumulo/core/clientImpl/TableOperationsImpl.java:
##########
@@ -1124,6 +1124,13 @@ private Map<String,String>
modifyPropertiesUnwrapped(String tableName,
Throwable cause = ae.getCause();
if (cause instanceof TableNotFoundException) {
throw new TableNotFoundException(null, tableName, null, ae);
+ } else if (cause instanceof ThriftTableOperationException) {
+ var ttoe = (ThriftTableOperationException) cause;
+ if (ttoe.getType() == TableOperationExceptionType.NAMESPACE_NOTFOUND) {
+ throw new TableNotFoundException(tableName, new
NamespaceNotFoundException(ttoe));
+ } else if (ttoe.getType() == TableOperationExceptionType.NOTFOUND) {
+ throw new TableNotFoundException(ttoe);
+ }
Review Comment:
If this change looks good, potentially other areas in TableOperationsImpl,
NamespaceOperationsImpl, SecurityOperationsImpl, and/or InstanceOperationsImpl
which handling of a thrift exception can be pushed closer to thrift code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
