dlmarion commented on PR #5708:
URL: https://github.com/apache/accumulo/pull/5708#issuecomment-3046450454

   @keith-turner  - I think I addressed your comments in the changes in commit 
8b4b0ef.
   
   `Property.isFixedZooProperty` is used to:
     1. log a warning in the Shell when changing a fixed property 
(ConfigCommand)
     2. log a warning in the Manager log when a fixed property is updated 
(SystemPropUtil.logIfFixed)
     3. mark properties as mutable in the generated documentation 
(ConfigurationDocGen)
     
   Since the code does not currently prevent a fixed property from being 
changed, `RuntimeFixedProperties` was used to return static property values for 
fixed properties.
   
   In 8b4b0ef, I removed `RuntimeFixedProperties` allowing properties to change 
values and allowing the determination of whether something is fixed or not to 
whether or not the code checks the value again. The 
`SystemConfiguration.ChangedPropertyMonitor` will log when property values have 
been changed but not read.
   
   I'm trying to figure out what to do with the `Property.FIXED_PROPERTIES` 
set. I don't have an issue removing the logging mentioned in 1 and 2 above, but 
wonder how we want to handle the user documentation. Certainly there are 
properties that are fixed (rpc, instance, port properties, block cache 
properties, etc.).
   
   My current thought is to remove `Property.FIXED_PROPERTIES` because almost 
everything is updateable and the code that enforced a static view was just 
removed. Instead, I'm thinking of adding an annotation to each Property to 
document the scope of the property. For example, rpc , instance, port 
properties, block cache properties, etc. have a PROCESS scope. Other 
properties, like MANAGER_BULK_TIMEOUT, may have a SESSION scope where they are 
checked each time. Maybe there are other values for other cases. If no 
annotation is supplied, then maybe there is a default value which means that 
its configurable. This approach continues to allow us to provide documentation, 
but if the annotation is wrong it's a documentation problem and doesn't affect 
the behavior of the code.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to