keith-turner commented on code in PR #5726:
URL: https://github.com/apache/accumulo/pull/5726#discussion_r2195312360


##########
server/base/src/main/java/org/apache/accumulo/server/compaction/FileCompactor.java:
##########
@@ -560,9 +582,15 @@ private void compactLocalityGroup(String lgName, 
Set<ByteSequence> columnFamilie
       SystemIteratorEnvironment iterEnv =
           env.createIteratorEnv(context, acuTableConf, getExtent().tableId());
 
-      SortedKeyValueIterator<Key,Value> itr = 
iterEnv.getTopLevelIterator(IteratorConfigUtil
-          .convertItersAndLoad(env.getIteratorScope(), cfsi, acuTableConf, 
iterators, iterEnv));
+      SortedKeyValueIterator<Key,Value> stack = null;
+      try {
+        stack = IteratorConfigUtil.convertItersAndLoad(env.getIteratorScope(), 
cfsi, acuTableConf,

Review Comment:
   > Do you think we should add ReflectiveOperationException to this catch 
clause so that Compactors die if there is any issue loading iterator classes?
   
   Personally I would not want all compactors to die if bad config w/ an 
incorrect class name was placed on a tables iterator settings.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to