ddanielr commented on code in PR #5729:
URL: https://github.com/apache/accumulo/pull/5729#discussion_r2195760253


##########
server/monitor/src/main/java/org/apache/accumulo/monitor/EmbeddedWebServer.java:
##########
@@ -57,7 +57,11 @@ public EmbeddedWebServer(Monitor monitor, int port) {
     handler =
         new ServletContextHandler(ServletContextHandler.SESSIONS | 
ServletContextHandler.SECURITY);
     handler.getSessionHandler().getSessionCookieConfig().setHttpOnly(true);
-    handler.setContextPath("/");
+    // Remove trailing slash since jetty will warn otherwise

Review Comment:
   if the context path is an empty string then it will fail the leading slash 
check in the Monitor.java code (line 457) and always result in `"/"` being the 
context root.
   
   I will update this "endsWith" check to include a length check so we are 
aren't trying to take a substring of a single char string. 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to