dlmarion commented on code in PR #5726:
URL: https://github.com/apache/accumulo/pull/5726#discussion_r2208209077


##########
core/src/main/java/org/apache/accumulo/core/spi/common/ContextClassLoaderFactory.java:
##########
@@ -66,5 +68,5 @@ default void init(ContextClassLoaderEnvironment env) {}
    *        consulting this plugin.
    * @return the class loader for the given contextName
    */
-  ClassLoader getClassLoader(String contextName);
+  ClassLoader getClassLoader(String contextName) throws IOException, 
ReflectiveOperationException;

Review Comment:
   I don't have an opinion on this either way, except that whatever is thrown 
should be a checked exception so that it must be handled. Using a 
RuntimeException is part of the reason for this PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to