dlmarion commented on code in PR #5726:
URL: https://github.com/apache/accumulo/pull/5726#discussion_r2211046337
##########
server/compactor/src/main/java/org/apache/accumulo/compactor/Compactor.java:
##########
@@ -243,6 +269,22 @@ public void registerMetrics(MeterRegistry registry) {
.builder(METRICS_COMPACTOR_ENTRIES_WRITTEN, this,
Compactor::getTotalEntriesWritten)
.description("Number of entries written by all compactions that have
run on this compactor")
.register(registry);
+ FunctionCounter
+ .builder(METRICS_COMPACTOR_COMPACTIONS_CANCELLED, this,
Compactor::getCancellations)
+ .description("Number compactions that have been cancelled on this
compactor")
+ .register(registry);
+ FunctionCounter
+ .builder(METRICS_COMPACTOR_COMPACTIONS_COMPLETED, this,
Compactor::getCompletions)
+ .description("Number compactions that have succeeded on this
compactor").register(registry);
+ FunctionCounter.builder(METRICS_COMPACTOR_COMPACTIONS_FAILED, this,
Compactor::getFailures)
+ .description("Number compactions that have failed on this
compactor").register(registry);
+ FunctionCounter.builder(METRICS_COMPACTOR_FAILURES_TERMINATION, this,
Compactor::getTerminated)
Review Comment:
The changes in my last commits having to deal with `AbstractServer.close`
were actually to close the ServerContext so that the MeterRegistry gets closed.
Closing the MeterRegistry's may end up doing a final poll on the metrics before
closing down. It looks like the StatsD implementation does that anyway. But I
agree, it's best effort and may not be guaranteed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
