dlmarion commented on code in PR #5749:
URL: https://github.com/apache/accumulo/pull/5749#discussion_r2223908074
##########
shell/src/main/java/org/apache/accumulo/shell/commands/ConfigCommand.java:
##########
@@ -436,6 +480,8 @@ public Options getOptions() {
outputFileOpt = new Option("o", "output", true, "local file to write the
scan output to");
namespaceOpt = new Option(ShellOptions.namespaceOption, "namespace", true,
"namespace to display/set/delete properties for");
+ resourceGroupOpt = new Option(ShellOptions.resourceGroupOption,
"resourceGroup", true,
Review Comment:
Not that the `rg` option is only for setting or deleting a resource group
property. The ConfigCommand displays all resource group values when listing
properties. The command currently does not display a single resource groups
configuration based on the `rg` property due to the system configuration merged
view issue noted in a different comment. It may be possible though, to use the
`rg` property to determine which host to connect to (instead of random).
##########
shell/src/main/java/org/apache/accumulo/shell/commands/ConfigCommand.java:
##########
@@ -187,6 +205,10 @@ public int execute(final String fullCommand, final
CommandLine cl, final Shell s
try {
systemConfig
.putAll(shellState.getAccumuloClient().instanceOperations().getSystemConfiguration());
+ Shell.log.warn("System configuration is dependent on the server's site
configuration and"
Review Comment:
Should only print this once per shell session. It's too verbose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
