keith-turner commented on code in PR #5763:
URL: https://github.com/apache/accumulo/pull/5763#discussion_r2231957223
##########
server/base/src/main/java/org/apache/accumulo/server/metadata/ConditionalTabletsMutatorImpl.java:
##########
@@ -78,6 +83,13 @@ public ConditionalTabletsMutatorImpl(ServerContext context,
Function<DataLevel,String> tableMapper) {
this.context = context;
this.tableMapper = Objects.requireNonNull(tableMapper);
+ this.sharedWriter = Suppliers.memoize(() -> {
Review Comment:
Seems like the creation of this sharedWriter is not in the correct place,
probably needs to be in ServerAmpleImpl. For code like
[this](https://github.com/apache/accumulo/blob/7ca25836e11a46fd312baa11fc4c191f1369bb87/server/manager/src/main/java/org/apache/accumulo/manager/tableOps/split/UpdateTablets.java#L202)
when it calls `getAmple().conditionallyMutateTablets()` that would still
create a new ConditionalWriter.
Maybe something like `Map<DataLevel, Supplier<ConditionalWriter>>` needs to
be passed into this constructor from ServerAmpleImpl.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
