keith-turner commented on issue #5767:
URL: https://github.com/apache/accumulo/issues/5767#issuecomment-3133089721

   Made the following change to the test and it prints `here`. So the test is 
working in that it is catching the expected exception.  However it seems like 
something deletes the lock that test `TestManager` had in zookeeper after that. 
 That causes the `TestManager` object to halt the process which in this case is 
the process running the test.  That makes junit unhappy and it declares the 
test a failure.  Not sure what is deleting the lock.  Did find that 
MiniAccumulo will call zoozap as  an after test action, but not sure if that is 
the cause yet.
   
   
   ```diff
    --git a/test/src/main/java/org/apache/accumulo/test/upgrade/UpgradeIT.java 
b/test/src/main/java/org/apache/accumulo/test/upgrade/UpgradeIT.java
   index 165ff174dc..a8c3bc38ab 100644
   --- a/test/src/main/java/org/apache/accumulo/test/upgrade/UpgradeIT.java
   +++ b/test/src/main/java/org/apache/accumulo/test/upgrade/UpgradeIT.java
   @@ -45,6 +45,7 @@ import org.apache.accumulo.server.ServerContext;
    import org.apache.accumulo.test.util.Wait;
    import org.apache.hadoop.conf.Configuration;
    import org.junit.jupiter.api.Test;
   +import org.slf4j.LoggerFactory;
    
    public class UpgradeIT extends AccumuloClusterHarness {
    
   @@ -144,6 +145,7 @@ public class UpgradeIT extends AccumuloClusterHarness {
        args.add(getCluster().getAccumuloPropertiesPath());
        try (TestManager mgr = new TestManager(args.toArray(new String[0]))) {
          IllegalStateException ise = assertThrows(IllegalStateException.class, 
() -> mgr.runServer());
   +      LoggerFactory.getLogger(UpgradeIT.class).info("here");
          assertTrue(ise.getMessage().equals("Upgrade not started, " + 
Constants.ZUPGRADE_PROGRESS
              + " node does not exist. Did you run 'accumulo upgrade 
--start'?"));
        }
   `diff
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to