ctubbsii commented on code in PR #5616:
URL: https://github.com/apache/accumulo/pull/5616#discussion_r2277942942
##########
core/src/main/java/org/apache/accumulo/core/spi/metrics/LoggingMeterRegistryFactory.java:
##########
@@ -49,6 +54,21 @@
* <pre>
* general.custom.metrics.opts.logging.step = 10s
* </pre>
+ *
+ * To filter out meters that start with any particular prefix, set
+ * {@code general.custom.metrics.opts.meter.id.filters} in the Accumulo
configuration.
+ *
+ * <pre>
+ * general.custom.metrics.opts.meter.id.filters = prefix1,prefix2,prefix3
+ *
+ * </pre>
+ *
+ * To assign a custom delimiter to filters, set
+ * {@code general.custom.metrics.opts.meter.id.delimiter} in the Accumulo
configuration.
Review Comment:
Instead of making the delimiter configurable, a different way of doing this,
one that is more consistent with how we have set other properties, would be to
support something like:
```
general.custom.metrics.loggingfactory.filter.exclude.1=prefix1
general.custom.metrics.loggingfactory.filter.exclude.2=prefix2
general.custom.metrics.loggingfactory.filter..exclude.3=prefix3
```
That way you don't have to worry about a delimiter at all.
Alternatively, make it a single regex filter:
```
general.custom.metrics.loggingfactory.filter.deny.regex=^(prefix1|prefix2|prefix3).*$
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
