kevinrr888 commented on issue #5787: URL: https://github.com/apache/accumulo/issues/5787#issuecomment-3192306549
> I think the FatePoolsWatcherITBase.testIncrease1 has some issues. First, each test method has a variable allAssertsOccurred that is used in the finally block to check that each assertion was checked. I don't think this is necessary and it hides the actual error that causes the test to fail. @DomGarguilo fixed this with https://github.com/apache/accumulo/pull/5790 > Second issue, which I'm not quite sure how to fix at this point, is that PoolResizeTestRepo.isReady waits on a latch indefinitely. In testIncrease1 the configuration is changed which is supposed to shutdown the FateExecutor running the transactions. But the Fate transactions are blocked on the latch and don't shut down. This is intended and not an issue, this is to test that transaction runners are not stopped in the middle of executing a fate op when a shutdown/config change occurs. See this check: ``` // The FateExecutor assigned to SET2 is no longer valid after the config change, so a // shutdown should be initiated and all the runners but the one working on a transaction // should be stopped. assertEquals(1, fate.getTxRunnersActive(set2)); ``` We later allow the work to complete and the shutdown to finish with ``` // finish work env.isReadyLatch.countDown(); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
