ctubbsii commented on code in PR #5810:
URL: https://github.com/apache/accumulo/pull/5810#discussion_r2289299849


##########
test/src/main/java/org/apache/accumulo/test/compaction/ExternalCompaction_1_IT.java:
##########
@@ -425,15 +425,19 @@ private void 
verifyCompactionCommitAndDead(FateStore<Manager> fateStore, TableId
       FateId fateId, List<ExternalCompactionId> cids) {
     var ctx = getCluster().getServerContext();
 
+    System.out.println("cids:" + cids);

Review Comment:
   Alternatively, can use slf4j logger in test code like we do in non-test 
code. It looks like maven-surefire-plugin uses slf4j-simple to handle slf4j 
logging from tests and collect them in the test output files, but print 
statements like these will probably just land on the regular console in the 
middle of the build. We do configure surefire to redirect STDOUT to a file, but 
it's probably better to just use logging.
   
   This isn't really important here, though... we have tests that do both, and 
we aren't very consistent about it. So, either is fine today.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to