keith-turner commented on code in PR #88:
URL: https://github.com/apache/accumulo-proxy/pull/88#discussion_r2291684866
##########
pom.xml:
##########
@@ -476,6 +479,19 @@
</plugins>
</pluginManagement>
<plugins>
+ <plugin>
Review Comment:
The accumulo pom specifies license text
[here](https://github.com/apache/accumulo/blob/3a0d8e5c72915fb4c7ce26d6156d15b0a444fb71/pom.xml#L669).
This seems to somehow know to use the apache license w/o doing that, maybe
its using the license section earlier in the pom?
##########
src/main/python/accumulo/AccumuloProxy.py:
##########
@@ -15,12 +16,6 @@
# specific language governing permissions and limitations
# under the License.
#
-# Autogenerated by Thrift Compiler (0.17.0)
Review Comment:
This comment generated by thrift is being removed by the plugin, which is
probably fine. I looked at the docs for the plugin and looked at how accumulo
is using the plugin and did not see any way to avoid removing this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
