keith-turner commented on PR #5811:
URL: https://github.com/apache/accumulo/pull/5811#issuecomment-3211754638
> In any other thread, the VM would be halted without closing. I'm thinking
that the finally block from AbstractServer.startServer should be removed.
Thoughts?
Are you thinking of something like the following? This would only call
close when there is no exception in runServer.
```java
public static void startServer(AbstractServer server, Logger LOG) throws
Exception {
try {
server.runServer();
server.close();
} catch (Exception e) {
System.err
.println(server.getClass().getSimpleName() + " died, exception
thrown from runServer.");
e.printStackTrace();
LOG.error("{} died, exception thrown from runServer.",
server.getClass().getSimpleName(), e);
throw e;
}
}
```
Or is the call to close() not needed at all in this code because of the
comment about `AbstractServer.close()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
