keith-turner commented on code in PR #5785:
URL: https://github.com/apache/accumulo/pull/5785#discussion_r2299015550
##########
core/src/main/java/org/apache/accumulo/core/fate/Fate.java:
##########
@@ -572,4 +572,10 @@ private void waitForDeadResCleanerShutdown(long start,
long timeout, TimeUnit ti
}
}
}
+
+ @Override
+ @SuppressWarnings("deprecation")
+ public final void finalize() {
+ // Prevent finalizer attacks (SpotBugs CT_CONSTRUCTOR_THROW)
+ }
Review Comment:
Avoding finalize here will be helpful in the future
https://openjdk.org/jeps/421
##########
core/src/main/java/org/apache/accumulo/core/fate/Fate.java:
##########
@@ -572,4 +572,10 @@ private void waitForDeadResCleanerShutdown(long start,
long timeout, TimeUnit ti
}
}
}
+
+ @Override
+ @SuppressWarnings("deprecation")
+ public final void finalize() {
+ // Prevent finalizer attacks (SpotBugs CT_CONSTRUCTOR_THROW)
+ }
Review Comment:
Avoiding finalize here will be helpful in the future
https://openjdk.org/jeps/421
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
