ctubbsii commented on issue #85: URL: https://github.com/apache/accumulo-proxy/issues/85#issuecomment-3235187505
I don't think this is needed. The reason this is needed is because the TServerUtils.java class required it to create a Thrift service. But that only exists as it does because it was copied from Accumulo. As such, it contains a lot of cruft that was needed to support all the capabilities in Accumulo but isn't needed in the proxy, which should be relatively lightweight. The stub is a workaround to satisfy the utility code's requirement, but the utility code should instead be cleaned up to not require it. A lot of the TServerUtils.java code could be cleaned up and simplified. Ultimately, the goal is to stop depending on internal Accumulo code, and just depend on its public API classes. The reason it's not that way today is just because starting up a Thrift service has a lot of steps, and we already wrote a lot of it for other Accumulo services, so we just reused it here... originally by calling in to that library, and now by calling into a copied portion of it. I'll close this, because I don't think we need to do this. Instead, the Thrift setup code should be simplified. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
