kevinrr888 commented on code in PR #5868:
URL: https://github.com/apache/accumulo/pull/5868#discussion_r2325653981
##########
core/src/main/java/org/apache/accumulo/core/conf/Property.java:
##########
@@ -147,37 +167,46 @@ public enum Property {
"1.3.5"),
@Sensitive
INSTANCE_SECRET("instance.secret", "DEFAULT", PropertyType.STRING,
- "A secret unique to a given instance that all servers must know in order"
- + " to communicate with one another. It should be changed prior to
the"
- + " initialization of Accumulo. To change it after Accumulo has been"
- + " initialized, use the ChangeSecret tool and then update
accumulo.properties"
- + " everywhere. Before using the ChangeSecret tool, make sure
Accumulo is not"
- + " running and you are logged in as the user that controls Accumulo
files in"
- + " HDFS. To use the ChangeSecret tool, run the command:
`./bin/accumulo"
- + " admin changeSecret`.",
+ // @formatter:off
+ """
+ A secret unique to a given instance that all servers must know in
order \
+ to communicate with one another. It should be changed prior to the \
+ initialization of Accumulo. To change it after Accumulo has been \
+ initialized, use the ChangeSecret tool and then update
accumulo.properties \
+ everywhere. Before using the ChangeSecret tool, make sure Accumulo
is not \
+ running and you are logged in as the user that controls Accumulo
files in \
+ HDFS. To use the ChangeSecret tool, run the command: `./bin/accumulo
\
+ admin changeSecret`.
+ """, // @formatter:on
Review Comment:
Turning the formatter off and on seems excessive. As far as I can tell, this
only prevents the final """ from aligning with the block which seems fine to
allow. Maybe this is a consideration for the formatter plugin, which I believe
@ctubbsii wrote, but not really important.
I have no problem with the switch to a multi-line string for these cases
though, it is more legible since it aligns everything
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
