DomGarguilo commented on code in PR #5853:
URL: https://github.com/apache/accumulo/pull/5853#discussion_r2323240469


##########
core/src/test/java/org/apache/accumulo/core/file/rfile/bcfile/CompressionTest.java:
##########
@@ -285,8 +299,9 @@ public void testThereCanBeOnlyOne() throws 
InterruptedException, ExecutionExcept
             return true;
           });
         }
+        assertEquals(numTasks, list.size());
 
-        results.addAll(service.invokeAll(list));
+        ArrayList<Future<Boolean>> results = new 
ArrayList<>(service.invokeAll(list));
         // ensure that we

Review Comment:
   Took a second look at this Class and made commit 876667a. Sort of unrelated 
but I avoided using shared state between threads in two of the test cases 
changed here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to