ctubbsii commented on PR #5890:
URL: https://github.com/apache/accumulo/pull/5890#issuecomment-3309399397

   > These changes look good, still only partially understand the interaction 
between errorprone and log4j annotation processing though.
   
   The main thing is that we need to enumerate the processors when we use 
log4j-core (because it's the only way to explicitly exclude the 
GraalVMProcessor we don't need or want, which causes build failures), and we 
need to autodiscover them when we use errorprone (because I couldn't figure out 
the list of processors to enumerate and it didn't work the few times I tried to 
do it).
   
   The compromise with the profiles is that we skip the log4j-core 
PluginProcessor that we want, but only when we're doing errorprone checks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to