ctubbsii opened a new issue, #5904:
URL: https://github.com/apache/accumulo/issues/5904

   MiniAccumuloConfigImpl.useExistingInstance reads the existing instance 
properties using `SiteConfiguration.fromFile(accumuloProps).build()`, and then 
enumerates the entire thing (which would include any inherited 
DefaultConfiguration) into the siteConfigMap. It only needs to enumerate the 
properties actually set in the existing config file, so it shouldn't use 
SiteConfiguration here.
   
   Also, the accumuloConf variable is an instance variable rather than a local 
method variable when it doesn't need to be. There's a similar issue with the 
hadoopConf variable. There are related getter methods in the Impl class that 
can be deleted, too.
   
   This was discovered while investigating #5895. The fix in that PR also 
addresses the problem seen in ExistingMacIT, but this would also fix it, and 
minicluster really shouldn't be copying over the default configuration 
properties when the existing instance hasn't explicitly set them, so this 
should also be fixed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to