dlmarion commented on code in PR #5865:
URL: https://github.com/apache/accumulo/pull/5865#discussion_r2355553655
##########
server/base/src/main/java/org/apache/accumulo/server/conf/cluster/ClusterConfigParser.java:
##########
@@ -159,8 +159,12 @@ private static void validateConfiguredGroups(final
ServerContext ctx, final Set<
if (!zkGroups.contains(cg)) {
if (createMissingRG) {
try {
- ctx.resourceGroupOperations().create(ResourceGroupId.of(cg));
- } catch (AccumuloException | AccumuloSecurityException e) {
+ // cant use API as servers may not be up when this is called
+ // from accumulo-cluster
+ final ResourceGroupId rgid = ResourceGroupId.of(cg);
+ final ResourceGroupPropKey key = ResourceGroupPropKey.of(rgid);
+ key.createZNode(ctx.getZooSession().asReaderWriter());
+ } catch (KeeperException | InterruptedException e) {
Review Comment:
Are you saying that you think we should remove the `createMissingRG` option
entirely, or just move the code added in this PR? I'm thinking you mean the
former, but I don't know that we have an admin tool that creates configuration
nodes in ZK for tables, namespaces, and system configs. The only tool that I
know of that does this is the Shell which ends up calling the Manager's Thrift
API.
I'm not sure that we need to future-proof this code right now. This change
could be made in the PR that removes `ClusterConfigParser` in favor of `yq`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
