ctubbsii commented on code in PR #5940:
URL: https://github.com/apache/accumulo/pull/5940#discussion_r2392850302
##########
pom.xml:
##########
@@ -1745,5 +1747,16 @@ under the License.
</plugins>
</build>
</profile>
+ <profile>
+ <id>uniq-test-dirs</id>
+ <activation>
+ <property>
+ <name>uniq-test-dirs</name>
+ </property>
+ </activation>
+ <properties>
+ <accumulo.it.uniq.test.dir>true</accumulo.it.uniq.test.dir>
+ </properties>
+ </profile>
Review Comment:
I don't think we need to have all 3 of:
1. the profile `-Puniq-test-dirs`,
2. the property `-Daccumulo.it.uniq.test.dir=true`, and
3. the property that activates the profile that sets the property
`-Duniq-test-dirs`
That's a bit excessive. Maintaining build profiles gets complicated, and it
gets tricky to reason about their activation when there are so many levers.
Usually, we try to only add new profiles when we need to manage multiple
things, or at least something more than a single property.
I suggest removing the profile, and just keeping the single property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
