kevinrr888 commented on code in PR #5949:
URL: https://github.com/apache/accumulo/pull/5949#discussion_r2414985929
##########
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/availability/LockTable.java:
##########
@@ -48,10 +51,18 @@ public LockTable(TableId tableId, NamespaceId namespaceId,
TRange range,
@Override
public long isReady(FateId fateId, Manager manager) throws Exception {
+ final Range range = new Range(tRange);
+ final RowRange rowRange = RowRange.range(
+ range.isInfiniteStartKey() ? null : range.getStartKey().getRow(),
+ range.isStartKeyInclusive(), range.isInfiniteStopKey() ? null :
range.getEndKey().getRow(),
+ range.isEndKeyInclusive());
+ final LockRange lockRange = LockRange.of(rowRange);
Review Comment:
Is the RowRange object needed here? Seems like more info is computed than
needed (inclusive start/end). Can just have
`final LockRange lockRange = LockRange.of(range.isInfiniteStartKey() ? null
: range.getStartKey().getRow(), range.isInfiniteStopKey() ? null :
range.getEndKey().getRow())`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
